fix: restore support for declare option exist:timeout "-1" to disable timeout#6081
fix: restore support for declare option exist:timeout "-1" to disable timeout#6081joewiz wants to merge 1 commit intoeXist-db:developfrom
Conversation
joewiz
force-pushed
the
fix/issue-2529-timeout-option
branch
3 times, most recently
from
8fab6b7 to
326b637
Compare
Ubuntu CI timeout analysisThe Why we suspect this PR isn't the cause:
Why only ubuntu is affected: The CI matrix excludes Windows and macOS from the Likely culprit: Known flaky infrastructure tests like We welcome other ideas about what might be causing this timeout. 🤖 Co-authored by Claude Code |
|
We should put a hold on this one, until the open xsuite PRs are in. The hang is a concern, imv. |
…able timeout The setTimeoutFromOption() method stored negative values (like -1) directly as the timeout, causing queries to be immediately terminated since elapsed > -1 is always true. The configureDefaults() method already handled this correctly by treating values <= 0 as Long.MAX_VALUE (infinite), but this guard was missing from setTimeoutFromOption(). Fixes eXist-db#2529 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joewiz
force-pushed
the
fix/issue-2529-timeout-option
branch
from
326b637 to
7c37dd3
Compare
3 participants
Summary
declare option exist:timeout "-1"(or"0")setTimeoutFromOption()was missing the<= 0guard thatconfigureDefaults()already had, causing negative values to be stored directly as the timeout — sinceelapsed > -1is always true, queries were immediately terminatedXQueryWatchDogTestwith 7 unit tests covering positive, zero, negative, invalid, and multi-value timeout optionsFixes #2529
Test plan
XQueryWatchDogTestpasses (7/7 tests)declare option exist:timeout "-1";no longer causes immediate query termination in a running eXist-db instance🤖 Generated with Claude Code